[llvm] 2b494f8 - [CVP] Remove -cvp-dont-add-nowrap-flags option

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2021-03-07T18:19:31+01:00
New Revision: 2b494f85f10ab79f41e74c8e75d707825f8cc110

URL: https://github.com/llvm/llvm-project/commit/2b494f85f10ab79f41e74c8e75d707825f8cc110
DIFF: https://github.com/llvm/llvm-project/commit/2b494f85f10ab79f41e74c8e75d707825f8cc110.diff

LOG: [CVP] Remove -cvp-dont-add-nowrap-flags option

This option was originally added to work around a bug in LFTR.
The bug has long since been fixed.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
    llvm/test/Transforms/CorrelatedValuePropagation/add.ll
    llvm/test/Transforms/CorrelatedValuePropagation/mul.ll
    llvm/test/Transforms/CorrelatedValuePropagation/shl.ll
    llvm/test/Transforms/CorrelatedValuePropagation/sub.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp b/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
index b671d68031a8..02d2bacabecb 100644
--- a/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
+++ b/llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
@@ -86,8 +86,6 @@ STATISTIC(NumOverflows, "Number of overflow checks removed");
 STATISTIC(NumSaturating,
     "Number of saturating arithmetics converted to normal arithmetics");
 
-static cl::opt<bool> DontAddNoWrapFlags("cvp-dont-add-nowrap-flags", cl::init(false));
-
 namespace {
 
   class CorrelatedValuePropagation : public FunctionPass {
@@ -843,9 +841,6 @@ static bool processSExt(SExtInst *SDI, LazyValueInfo *LVI) {
 static bool processBinOp(BinaryOperator *BinOp, LazyValueInfo *LVI) {
   using OBO = OverflowingBinaryOperator;
 
-  if (DontAddNoWrapFlags)
-    return false;
-
   if (BinOp->getType()->isVectorTy())
     return false;
 

diff  --git a/llvm/test/Transforms/CorrelatedValuePropagation/add.ll b/llvm/test/Transforms/CorrelatedValuePropagation/add.ll
index 026af75220df..e58a7e2ddf8b 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/add.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/add.ll
@@ -1,4 +1,4 @@
-; RUN: opt < %s -correlated-propagation -cvp-dont-add-nowrap-flags=false -S | FileCheck %s
+; RUN: opt < %s -correlated-propagation -S | FileCheck %s
 
 ; CHECK-LABEL: @test0(
 define void @test0(i32 %a) {

diff  --git a/llvm/test/Transforms/CorrelatedValuePropagation/mul.ll b/llvm/test/Transforms/CorrelatedValuePropagation/mul.ll
index 288d114cb370..b3b579be7654 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/mul.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/mul.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -correlated-propagation -cvp-dont-add-nowrap-flags=false -S | FileCheck %s
+; RUN: opt < %s -correlated-propagation -S | FileCheck %s
 
 define i8 @test0(i8 %a) {
 ; CHECK-LABEL: @test0(

diff  --git a/llvm/test/Transforms/CorrelatedValuePropagation/shl.ll b/llvm/test/Transforms/CorrelatedValuePropagation/shl.ll
index 0514ec95bdbf..17e65cde1f43 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/shl.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/shl.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -correlated-propagation -cvp-dont-add-nowrap-flags=false -S | FileCheck %s
+; RUN: opt < %s -correlated-propagation -S | FileCheck %s
 
 define i8 @test0(i8 %a, i8 %b) {
 ; CHECK-LABEL: @test0(

diff  --git a/llvm/test/Transforms/CorrelatedValuePropagation/sub.ll b/llvm/test/Transforms/CorrelatedValuePropagation/sub.ll
index 091059c0b2df..696665f6e3cb 100644
--- a/llvm/test/Transforms/CorrelatedValuePropagation/sub.ll
+++ b/llvm/test/Transforms/CorrelatedValuePropagation/sub.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -correlated-propagation -cvp-dont-add-nowrap-flags=false -S | FileCheck %s
+; RUN: opt < %s -correlated-propagation -S | FileCheck %s
 
 define void @test0(i32 %a) {
 ; CHECK-LABEL: @test0(