[PATCH] D98085: [AMDGPU] Always expand system scope fp atomics on gfx90a

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 18:23:36 PST 2021


rampitec added a comment.

A side note: one in fact needs to be extremely lucky or insistent to get these instructions. First a proper C(++) atomic has to be used. Then denorm mode must match. Then usafe atomics option has to be used. A return value must be ignored on gfx908. Now the scope must be non-default and less than system. I wander if anyone will ever use it at all. Stars really need to align for someone to get it, and then he/she must be careful not to violate all these promises. Oh, well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98085/new/

https://reviews.llvm.org/D98085



More information about the llvm-commits mailing list