[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 7 07:24:15 PST 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrCompiler.td:103
+          (TCRETURNj (MOV32af_TC MxARII32:$dst), imm:$adj)>,
+          Requires<[IsNotPIC]>;
+
----------------
As above


================
Comment at: llvm/lib/Target/M68k/M68kInstrData.td:524-526
+      MxEncoding<EA.Reg, EA.DA, EA.Mode,
+                 MxBead4Bits<0b1011>, MxBead4Bits<0b0000>, MxBead2Bits<0b01>,
+                 EXT.Imm, EXT.B8, EXT.Scale, EXT.WL, EXT.DAReg>>,
----------------
These 3 lines are still underindented


================
Comment at: llvm/lib/Target/M68k/M68kInstrData.td:527
+                 EXT.Imm, EXT.B8, EXT.Scale, EXT.WL, EXT.DAReg>>,
+                 Requires<[ IsM68010 ]>;
+
----------------
No this was right before, now it's wrong


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389



More information about the llvm-commits mailing list