[PATCH] D98132: [RISCV} Fold (select_cc (setlt X, Y), 0, ne, trueV, falseV) -> (select_cc X, Y, lt, trueV, falseV)

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 7 07:03:53 PST 2021


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3803
+        LHS.getOperand(0).getValueType() == Subtarget.getXLenVT()) {
+      // If We're looking for eq 0 instead of ne 0, we need to invert the
+      // condition.
----------------
Nit: "We're" capitalization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98132/new/

https://reviews.llvm.org/D98132



More information about the llvm-commits mailing list