[PATCH] D97961: [Cost]Canonicalize the cost for logical or/and reductions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:1909
+      // FIXME: some targets did not implement cost for vector-to-int bitcast.
+      return getCastInstrCost(Instruction::BitCast, ValTy, Ty,
+                              TTI::CastContextHint::None, CostKind) +
----------------
ABataev wrote:
> SystemZ cost model does not implement vector-to-int bitcast and crashes. That's why have to use `Base::getCastInstrCost()` here rather than `thisT()->getCastInstrCost()`
How much of a task would it be to tweak the SystemZ TTI to avoid this? I worry that this kind of thing gets forgotten about and could cause other problems in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97961/new/

https://reviews.llvm.org/D97961