[PATCH] D98120: [InstCombine] Remove a provenance changing gep transformation

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D98120#2609269 <https://reviews.llvm.org/D98120#2609269>, @nikic wrote:

> The remaining fold (both here and in InstSimplify) is only valid if both pointers have the same provenance, i.e. getUnderlyingObject() is the same.

That's a good point, this fold should be somewhat good iff we can prove that it doesn't miscompile.

In D98120#2609269 <https://reviews.llvm.org/D98120#2609269>, @nikic wrote:

> I don't know what the fallout of enforcing that would be.

Ack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98120/new/

https://reviews.llvm.org/D98120