[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata
Shilei Tian via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 6 20:09:50 PST 2021
tianshilei1992 added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3679
S.Diag(AL.getLoc(), diag::err_attribute_wrong_number_arguments)
- << AL << (unsigned)(EncodingIndices.size() - 1);
+ << AL << (unsigned)(CalleeFnProtoType->getNumParams() + 2);
return;
----------------
Need to revise this line to see which is the right number passed here.
================
Comment at: llvm/include/llvm/IR/AbstractCallSite.h:55
struct CallbackInfo {
+ enum ParameterEncodingModeTy : int64_t {
+ FLATTEN = 0,
----------------
I guess this enum should be in a more common place such that other files can use it. Any suggestion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98134/new/
https://reviews.llvm.org/D98134
More information about the llvm-commits
mailing list