[PATCH] D98027: [NFC][AA] Convert AliasResult to scoped enumeration.

Sat Mar 6 12:27:03 PST 2021

rampitec added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:44-80
 // These arrays are indexed by address space value enum elements 0 ... to 7
+//                 Flat     | Global   | Region   | Group    | Constant | Private | Cnst 32b | BFPtr
+// ----------------------------------------------------------------------------------------------------
+// Flat            MayAlias | MayAlias | NoAlias  | MayAlias | MayAlias | MayAlias| MayAlias | MayAlias
+// Global          MayAlias | MayAlias | NoAlias  | NoAlias  | MayAlias | NoAlias | MayAlias | MayAlias
+// Region          NoAlias  | NoAlias  | MayAlias | NoAlias  | NoAlias  | NoAlias | NoAlias  | NoAlias
+// Group           MayAlias | NoAlias  | NoAlias  | MayAlias | NoAlias  | NoAlias | NoAlias  | NoAlias
----------------
dfukalov wrote:
> rampitec wrote:
> > dfukalov wrote:
> > > @rampitec, @arsenm, would you please take a look to this 'typography'? I moved out table comments since the table width increased significantly with `AliasResult::`s
> > Does it work with "using AliasResult;"?
> No, `using AliasResult::NoAlias;` in a block will be available since C++20.
> 
> At the moment I can place `using AR = AliasResult;` and then use `AR::` but it will increase current table width of 120 to 138.
Then I can only think about defines before the block and undefs after.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98027/new/

https://reviews.llvm.org/D98027