[PATCH] D97877: [DSE] Remove MemDep-based implementation

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 6 11:15:18 PST 2021


fhahn added a comment.

I think we could also move the tests out of the `MSSA` directory?



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:415
 /// overwrite \p Earlier.
 template <typename AATy>
 static OverwriteResult isMaskedStoreOverwrite(const Instruction *Later,
----------------
I think this can be dropped now as well?


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1524
 //=============================================================================
 // MemorySSA backed dead store elimination.
 //
----------------
Should we move the comment to the top of the file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97877/new/

https://reviews.llvm.org/D97877



More information about the llvm-commits mailing list