[PATCH] D97722: [NewPM] Revamp pass names

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for tackling this!

> I guess it wouldn't hurt if the pass names generally would match with the DEBUG_TYPE.
> ..
> A problematic thing with that here is that you can't simply move the DEBUG_TYPE definitions into the header files (well, it might be technically possible, but it might be problematic when including several header files that define the macros). One could ofcourse implement the name() methods in the the .cpp file, but that is also a bit messier implementation-wise.

Tying it to `DEBUG_TYPE` would indeed be great. I guess the main downside with implementing the function in the `.cpp` is that it doubles the number of files touched, but I am not sure if it is really that messy in terms of the code.

Is it possible to add a test checking the new names? I don't think it's worth to check all of them, but I think it would be good to have a test that checks that we generate some of the compact names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97722/new/

https://reviews.llvm.org/D97722