[PATCH] D98116: [NPM] Add -enable-loopinterchange option to NPM

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:758
+  if (EnableLoopInterchange)
+    LPM2.addPass(LoopInterchangePass()); // Interchange loops
+
----------------
nit: not sure the comment adds much, as it is directly in the pass name. (same as above)


================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:89
     "enable-loopinterchange", cl::init(false), cl::Hidden,
     cl::desc("Enable the new, experimental LoopInterchange Pass"));
 
----------------
while you are modifying the option, perhaps drop the `new` bit as well. It's not really new anymore :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98116/new/

https://reviews.llvm.org/D98116