[PATCH] D98086: [FileCheck] Fix CHECK-NOT numeric error diagnostics

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 6 04:27:46 PST 2021


jdenny added a comment.

> This patch also extends input dumps to include similar error
> diagnostics.

I realize now that the wording in this patch isn't general enough: it handles not only pattern errors but also overflow errors due to large values in the input.  I should extend the tests accordingly.  So far, I believe the logic in this patch is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98086/new/

https://reviews.llvm.org/D98086



More information about the llvm-commits mailing list