[PATCH] D97998: [CSSPGO] llvm-profdata support for CS profile.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:1908-1909
   cl::alias OutputA("o", cl::desc("Alias for --output"), cl::aliasopt(Output));
   cl::opt<bool> IsCS("cs", cl::init(false),
                      cl::desc("For context sensitive counts"));
   cl::opt<unsigned long long> ValueCutoff(
----------------
wmi wrote:
> This is not added for cs instrument fdo profile. Could you update the the description to differentiate with csspgo?
Good point, the switch is for CSPGO only.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:1915-1917
   cl::opt<std::string> FuncNameFilter(
       "function",
       cl::desc("Function level overlap information for matching functions"));
----------------
wmi wrote:
> Is it better to update the description for csspgo since the function filter will be used as context filter? similar for value-cutoff and similarity-cutoff.
Sounds good. They are applied to contexts with csspgo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97998/new/

https://reviews.llvm.org/D97998