[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:2146
+    // a line entry for any .loc directive that has been seen.
+    MCDwarfLineEntry::make(this, getCurrentSectionOnly());
+
----------------
This is more of a question for my own understanding: when do we need to call `MCDwarfLineEntry::make`?
It seems in MCObjectStreamer, we would also call `MCDwarfLineEntry::make` in `emitValueImpl` and `emitBytes`. Are those calls not necessary in the MCAsmStreamer counterpart?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518