[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

Tue Mar 2 03:03:47 PST 2021

shchenz added inline comments.

================
Comment at: llvm/test/DebugInfo/XCOFF/empty.ll:51
+; ASM32-NEXT:   li 4, 0
+; ASM32-NEXT:  L..tmp1:
+; ASM32-NEXT:  L..tmp2:
----------------
shchenz wrote:
> jasonliu wrote:
> > It might not be big deal, but it seems we are generating an extra label for no reason?
> Not sure, this should be also exist without -g.
> Not sure, this should be also exist without -g.

What I mean is these two labels are caused by input to MC DWARF generation. The `L..tmp2` is generated by a `.loc` directive. It will be used in dwlinesection. The `L..tmp1` is generated for other usage., I have not checked into this yet. But I guess this should not be related for XCOFF DWARF.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518