[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSectionXCOFF.h:109
   bool isCsect() const { return CsectProp.hasValue(); }
+  bool isDWARFSect() const { return DwarfSubtypeFlags.hasValue(); }
+  Optional<XCOFF::DwarfSectionSubtypeFlags> getDwarfSubtypeFlags() const {
----------------
Minor nit: We've been using `Dwarf` for `camelCase`.


================
Comment at: llvm/lib/MC/MCContext.cpp:679
+    Optional<XCOFF::DwarfSectionSubtypeFlags> DwarfSectionSubtypeFlags) {
+  bool IsDWARFSec = DwarfSectionSubtypeFlags.hasValue();
+  assert(((IsDWARFSec && !CsectProp.hasValue()) ||
----------------
Minor nit: We've been using `Dwarf` with `PascalCase`.


================
Comment at: llvm/lib/MC/MCContext.cpp:680-682
+  assert(((IsDWARFSec && !CsectProp.hasValue()) ||
+          (!IsDWARFSec && CsectProp.hasValue())) &&
+         "Invalid XCOFF section!");
----------------
Minor comment: `==` works for this check.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1804-1807
+  // When -function-sections is enabled, generating function section end symbol
+  // to tell debug line section where is the end of current function section.
+  if (TM.getFunctionSections() && !MAI->usesDwarfFileAndLocDirectives() &&
+      MMI->hasDebugInfo())
----------------
@jasonliu, I'd like your analysis of how this interacts with explicit sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518