[PATCH] D97978: [llvm] Change DSOLocalEquivalent type if the underlying global value type changes

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 14:39:31 PST 2021


phosek added a comment.

Is it feasible to cover this by a test?



================
Comment at: llvm/lib/Transforms/Utils/ValueMapper.cpp:415
 
+  if (const auto *Equiv = dyn_cast<DSOLocalEquivalent>(C)) {
+    auto *Val = mapValue(Equiv->getGlobalValue());
----------------
Super minor nit, I think that `E` would be more idiomatic here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97978/new/

https://reviews.llvm.org/D97978



More information about the llvm-commits mailing list