[PATCH] D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 14:27:40 PST 2021


clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-directive-structure.h:208
 
+  auto FindClauseMult(C type) {
+    auto it{GetContext().clauseInfo.equal_range(type)};
----------------
Is the name following a convention? What about `FindClauses` instead?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:620
+        if (alignedVars.count(var.ToString()) == 1) {
+          context_.Say(
+              itr->second->source,
----------------
Clang-format to be run on the patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97964/new/

https://reviews.llvm.org/D97964



More information about the llvm-commits mailing list