[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive

Fri Mar 5 12:54:40 PST 2021

rdwampler added a subscriber: tstellar.
rdwampler added a comment.

In D81803#2606948 <https://reviews.llvm.org/D81803#2606948>, @sbc100 wrote:

> In D81803#2592409 <https://reviews.llvm.org/D81803#2592409>, @nikic wrote:
>
>> Just FTR, this change had to be reverted in Rust's LLVM fork because it breaks compilation on Windows 7, see https://github.com/rust-lang/rust/issues/81051.
>
> Emscripten users also seem to be effect by this.  Specifically windows 7 users are seeing link failure: "wasm-ld: error: failed to write the output file: permission denied".
>
> https://github.com/emscripten-core/emscripten/issues/13067

This change was to fix a very narrow use case. Since it affecting all Windows 7 users, I think we should revert it. I can investigate if there's another way to work around the original issue. But until then,  is there still time to get this revert in the 12.0.0 release @tstellar?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803