[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

In D97915#2607567 <https://reviews.llvm.org/D97915#2607567>, @ychen wrote:

> In D97915#2607338 <https://reviews.llvm.org/D97915#2607338>, @rjmccall wrote:
>
>> Let's try to avoid adding a new builtin for what we acknowledge is a workaround.  Builtins become part of the language supported by the compiler, so we shouldn't add them casually.
>
> If we're going to use the aligned new in the future, do we still need this builtin, or something else is preferred?

Oh, sorry, for some reason I got the impression from the patch that we were adding a new Clang-level builtin.  Adding a new LLVM intrinsic seems reasonable to me.

In any case, I don't think we should expose BuiltinAlignArgs outside of CGBuiltin.cpp.  Seems like at most we need to add a convenience function on CGBuilderTy to do a pointer round-up-to-alignment operation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97915/new/

https://reviews.llvm.org/D97915