[PATCH] D97504: [llvm-exegesis] Disable the LBR check on AMD

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 09:57:09 PST 2021


oontvoo added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:507
+  if (!isCpuIdSupported())
+    return VendorSignatures::UNKNOWN;
+
----------------
ondrasej wrote:
> As noted in the other patch - when MaxLeaf is nullptr we should set it to zero if this return statement is used.
> 
> Otherwise, it will keep its default value and for the caller it will be impossible to distinguish this branch from the return statement on line 520.
Done. (Setting MaxLeaf to 0 when it's not null in the check on line 503)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97504/new/

https://reviews.llvm.org/D97504



More information about the llvm-commits mailing list