[PATCH] D97837: [InstCombine] Remove gc.relocate duplicates

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 09:39:57 PST 2021


reames added a comment.

Just to comment here - I'm not arguing that we shouldn't land this.  I'm simply wanting to make sure we fully understand the reasoning justifying it, and have fixed all the low hanging issues "nearby".

I do want to look into the "why isn't GVN and EarlyCSE combining two equivalent phi nodes" a bit.  Give me a bit to do that as having CSE handle this seems like a more natural fit than instcombine, but if that doesn't work out, I'm not opposed to doing this here since the scope of the CSE is so restricted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97837/new/

https://reviews.llvm.org/D97837



More information about the llvm-commits mailing list