[PATCH] D97979: [lld-macho] Check platform and version in constructor ObjFile

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 09:35:07 PST 2021


int3 added inline comments.


================
Comment at: lld/test/MachO/incompat-version.s:1
+# REQUIRES: x86
+
----------------
Can we merge this test into `invalid/incompatible-arch.s`? (and rename the file to `incompatible-target` or something). That test file is pretty small as-is and this test is covering very similar functionality.

(In general we put tests that only check for error handling into `invalid/`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97979/new/

https://reviews.llvm.org/D97979



More information about the llvm-commits mailing list