[PATCH] D98027: [NFC][AA] Convert AliasResult to scoped enumeration.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

This looks fine to me, though I'm not clear on how making it an enum class will help with moving to a class. Do you happen to have the patch for that already?



================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:77
 /// canonical names from the literature are suffixed and unique anyways, and so
 /// they serve as global constants in LLVM for these results.
 ///
----------------
This paragraph should be dropped.


================
Comment at: llvm/lib/Target/Hexagon/HexagonStoreWidening.cpp:183
     MemoryLocation SL(SMO.getValue(), SMO.getSize(), SMO.getAAInfo());
-    if (AA->alias(L, SL))
+    if (AA->alias(L, SL) != AliasResult::NoAlias)
       return true;
----------------
Could also write this as `AA->isNoAlias(L, SL)` (same in some following occurrences). No strong preference though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98027/new/

https://reviews.llvm.org/D98027