[PATCH] D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 09:09:11 PST 2021


sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

One minor comment but otherwise LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:458
+    if (!TM.getAIXExtendedAltivecABI() && Subtarget.isAIXABI())
+      return 64 - 12 - DefaultSafety;
+  }
----------------
Really minor nit: Either just use available register count like the other cases (ie 52 - DefaultSafety) or name the constant 12 something descriptive like 'DefaultAIXABIReservedVRCount` and use it in both places we have reduced register counts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351



More information about the llvm-commits mailing list