[PATCH] D98043: [LoopVectorize][SVE] Add tests for vectorising conditional loads of invariant addresses

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 08:02:39 PST 2021


david-arm added a comment.

In D98043#2606888 <https://reviews.llvm.org/D98043#2606888>, @joechrisellis wrote:

> LGTM -- the test is a little noisy but I suppose that's par for the course for this kind of check. 🙂

HI @joechrisellis thanks for the review! Yes, I tried to write in as few CHECK lines as I could, but I really wanted to ensure that the `inv` variable ended up as a splat in the gather and so on. Also, the geps and casts along the way have to be tracked unfortunately to ensure the masked gathers and loads are doing the expected thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98043/new/

https://reviews.llvm.org/D98043



More information about the llvm-commits mailing list