[PATCH] D98046: [TableGen] Fix excessive compile time issue in FixedLenDecoderEmitter

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 07:48:09 PST 2021


foad added a comment.

> D52100 <https://reviews.llvm.org/D52100> goes on to say that "fields are still permitted to exceed 64-bits
> so long as they aren't one contiguous string of bits". This patch breaks
> that by always using a "uint64_t tmp" in the generated decodeToMCInst,
> but it should be easy to fix in FilterChooser::emitBinaryParser by
> choosing to use a different type of tmp based on the known total field
> width.

I didn't try to implement the fix because I don't have a target that needs it so I wouldn't be able to test it. @dsanders do you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98046/new/

https://reviews.llvm.org/D98046



More information about the llvm-commits mailing list