[PATCH] D96394: [AVR] Improve inline assembly

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 05:58:44 PST 2021


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRRegisterInfo.td:177
+  (
+    add R15R14, R13R12, R11R10, R9R8, R7R6, R5R4, R3R2, R1R0
+  )>;
----------------
aykevl wrote:
> It seems to me this register class is not limited to these registers: R14R13 should also be included for example.
I am not sure R14R13 is necessary in this class (for `l`), since R20R19 is neither in the DLDREGS class (which corresponding to `d`). Although less optimized code may be generated without R14R13, it is still correct code.

I will do more careful test to see if R14R13 is needed here. Thank you.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96394/new/

https://reviews.llvm.org/D96394



More information about the llvm-commits mailing list