[PATCH] D97997: [X86][NFC] Move instruction selection of the x86_tdpb[s,u]d_internal and x86_tilezero_internal to X86InstrAMX.td

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 05:54:38 PST 2021


pengfei accepted this revision.
pengfei added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/X86/X86InstrAMX.td:51
     // Pseduo instruction for RA.
-    def PTILELOADDV : PseudoI<(outs TILE: $dst), (ins GR16:$src1,
-                                                      GR16:$src2,
-                                                      opaquemem:$src3), []>;
+    def PTILELOADDV : PseudoI<(outs TILE:$dst), (ins GR16:$src1,
+                                                     GR16:$src2,
----------------
Can we add patterns for the load and restore too?


================
Comment at: llvm/lib/Target/X86/X86InstrAMX.td:98
     let Constraints = "$src4 = $dst" in {
       def PTDPBSSDV : PseudoI<(outs TILE: $dst), (ins GR16:$src1,
                               GR16:$src2, GR16:$src3, TILE:$src4,
----------------
extra space.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97997/new/

https://reviews.llvm.org/D97997



More information about the llvm-commits mailing list