[PATCH] D97923: [WebAssembly][yaml2obj][obj2yaml] Elem sections for nonzero tables

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 02:48:12 PST 2021


wingo added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:316
+  WASM_ELEM_SEGMENT_HAS_INIT_EXPRS = 0x04,
+  WASM_ELEM_SEGMENT_MASK_HAS_ELEM_KIND = ~WASM_ELEM_SEGMENT_HAS_INIT_EXPRS
+};
----------------
sbc100 wrote:
> Do you think this should outside the enum perhaps?
fixed when pushed as
```
const unsigned WASM_ELEM_SEGMENT_MASK_HAS_ELEM_KIND = 0x3;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97923/new/

https://reviews.llvm.org/D97923



More information about the llvm-commits mailing list