[llvm] 47c343d - [llvm-objcopy][test] Fix test that could have passed spuriously

[James Henderson via llvm-commits]

Author: James Henderson
Date: 2021-03-05T08:57:39Z
New Revision: 47c343d7685f4ce9d8013c2e7ed3e30869875f4d

URL: https://github.com/llvm/llvm-project/commit/47c343d7685f4ce9d8013c2e7ed3e30869875f4d
DIFF: https://github.com/llvm/llvm-project/commit/47c343d7685f4ce9d8013c2e7ed3e30869875f4d.diff

LOG: [llvm-objcopy][test] Fix test that could have passed spuriously

The test was showing that when --strip-unneeded is specified for an
executable, all the symbols are stripped. However, the set of symbols
used in the test would be stripped by --strip-unneeded for an ET_REL
object too. Fix this by adding additional symbols that aren't normally
stripped by --strip-unneeded.

Reviewed by: MaskRay

Differential Revision: https://reviews.llvm.org/D97664

Added: 
    

Modified: 
    llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test b/llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test
index c66a52353158..859817c9c33b 100644
--- a/llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test
+++ b/llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test
@@ -2,20 +2,32 @@
 ## eliminate the static symbol table, because it's not used
 ## by the dynamic loader. 
 
-# RUN: yaml2obj %s -o %t
-# RUN: cp %t %t1
-# RUN: llvm-objcopy --strip-unneeded %t %t2
-# RUN: llvm-readobj --section-headers %t2 | FileCheck %s
+# RUN: yaml2obj %s -o %t.exec -DTYPE=EXEC
+# RUN: llvm-objcopy --strip-unneeded %t.exec %t2.exec
+# RUN: llvm-readobj --section-headers %t2.exec | FileCheck %s --check-prefix=NOSYMTAB
+## Sanity check that the symtab wouldn't be removed if the input were an ET_REL.
+# RUN: yaml2obj %s -o %t.rel -DTYPE=REL
+# RUN: llvm-objcopy --strip-unneeded %t.rel %t2.rel
+# RUN: llvm-readobj --section-headers %t2.rel | FileCheck %s --check-prefix=SYMTAB
 
 !ELF
 FileHeader:
   Class:    ELFCLASS64
   Data:     ELFDATA2LSB
-  Type:     ET_EXEC
+  Type:     ET_[[TYPE]]
   Machine:  EM_X86_64
+Sections:
+  - Name: .text
+    Type: SHT_PROGBITS
 Symbols:
-  - Name:     bar
-  - Name:     foo
+  - Name:     local_undef
+  - Name:     local_def
+    Section:  .text
+  - Name:     global_undef
+    Binding:  STB_GLOBAL
+  - Name:     global_def
+    Section:  .text
     Binding:  STB_GLOBAL
 
-# CHECK-NOT: .symtab
+# NOSYMTAB-NOT: .symtab
+# SYMTAB:       .symtab