[PATCH] D97663: [llvm-objcopy] Fix crash for binary input files with non-ascii names

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 00:55:13 PST 2021


jhenderson added a comment.

In D97663#2604828 <https://reviews.llvm.org/D97663#2604828>, @MaskRay wrote:

> Still worth clarifying that this is fixing UB, which may be a crash on some implementations (glibc? Though I cannot reproduce it).

Okay, I'll update the commit message. For reference, this crashed on Windows using VS2017 for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97663/new/

https://reviews.llvm.org/D97663



More information about the llvm-commits mailing list