[PATCH] D96679: [llvm-objdump] Implement --prefix-strip option

Fri Mar 5 00:41:17 PST 2021

jhenderson added a comment.

Sorry for the delay. I've been off sick for much of the week, and am still catching up on things.

================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:84
+
+; RUN: not llvm-objdump --prefix %p --prefix-strip '-1' --source %t-missing-prefix.o 2>&1 | \
+; RUN:   FileCheck %s --check-prefix=CHECK-NEGATIVE-PREFIX-STRIP
----------------
Another one that has occurred to me: testing a non-numeric value, e.g. "--prefix-strip=foo" to show an error is hit. Not 100% certain if it's necessary, but it ensures we have "invalid case" handling in place, in case negative numbers are ever accepted for some reason.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96679/new/

https://reviews.llvm.org/D96679