[PATCH] D97837: [InstCombine] Remove gc.relocate duplicates

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 19:49:48 PST 2021


skatkov added a comment.

Ok, I've checked GVN with your patch. The situation becomes the same as for EarlyCSE. To make a full clean-up we need

1. InstCombine to eliminate redundant phi
2. GVN to clean-up the chain of gc.relocation
3. InstCombine again to clean-up gc bundle

Interesting why GVN cannot remove the duplicated phi node?

So the final question whether we are ok to have all in one in InstCombine with this patch or want to build a clean-up pipeline.
What is your opinion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97837/new/

https://reviews.llvm.org/D97837



More information about the llvm-commits mailing list