[PATCH] D97996: [flang][fir] Add diagnostic tests for FIR ops verifier

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM, thanks!



================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:556
   if (op.getShape()) {
-    auto shapeTy = op.getShape().getType();
-    if (!(shapeTy.isa<fir::ShapeType>() || shapeTy.isa<ShapeShiftType>()))
-      return op.emitOpError("must be shape or shapeshift type");
     if (!isArray)
       return op.emitOpError("shape must not be provided for a scalar");
----------------
Nit: you can merge now: `if (op.getShape() && !isArray)`

(same below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97996/new/

https://reviews.llvm.org/D97996