[PATCH] D97929: [WebAssembly] Fix ExceptionInfo grouping again

Thu Mar 4 15:14:30 PST 2021

dschuff added inline comments.

================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:1564
+; should make sure to take out (c)'s exception out of (a)'s exception too.
+define void @test25() personality i8* bitcast (i32 (...)* @__gxx_wasm_personality_v0 to i8*) {
+entry:
----------------
aheejin wrote:
> dschuff wrote:
> > I don't see any CHECKs here. I guess the test is just to ensure there are no assert failures?
> Yes these regression tests are mostly to check they don't crash. Checking specific CFGStackify output is not very informative or not easy to verify by eyes. Maybe one more informative thing to dump or check is `WebAssemblyExceptionInfo::dump()`.. Maybe we can dump that info and check that.
that sounds like it could be useful. One thing to watch out for on that, is that (IIRC) some dumping methods get compiled away in release builds. I'm not sure what the common practice is for using those in tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97929/new/

https://reviews.llvm.org/D97929