[PATCH] D97956: [PowePC][AIX] Handle variadic vector call operands.
Zarko Todorovski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 4 15:03:32 PST 2021
ZarkoCA added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-vector-vararg-caller.ll:4
+; RUN: -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff < %s | \
+; RUN: FileCheck --check-prefixes=32BIT %s
+
----------------
nit: prefix instead of prefixes
================
Comment at: llvm/test/CodeGen/PowerPC/aix-vector-vararg-caller.ll:69
+ ; 32BIT: BLR implicit $lr, implicit $rm, implicit $v2
+ ; 64BIT-LABEL: name: caller
+ ; 64BIT: bb.0.entry:
----------------
Nit: An empty line between 32 and 64Bit.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-vector-vararg-caller.ll:69
+ ; 32BIT: BLR implicit $lr, implicit $rm, implicit $v2
+ ; 64BIT-LABEL: name: caller
+ ; 64BIT: bb.0.entry:
----------------
ZarkoCA wrote:
> Nit: An empty line between 32 and 64Bit.
Empty line between 32 and 64bit.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-vector-vararg-fixed-caller.ll:4
+; RUN: -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff < %s | \
+; RUN: FileCheck --check-prefixes=32BIT %s
+
----------------
nit: prefix instead of prefixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97956/new/
https://reviews.llvm.org/D97956
More information about the llvm-commits
mailing list