[PATCH] D97979: [lld-macho] Check platform and version in constructor ObjFile
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 4 14:27:12 PST 2021
int3 added a comment.
Neat. Could you clean up the clang-tidy issues? Kind of hard to review the code with all that in the way.
Also, I think the method is getting large enough, it would be nice to factor out the arch/platform check into a separate method.
Finally, don't forget about the test :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97979/new/
https://reviews.llvm.org/D97979
More information about the llvm-commits
mailing list