[PATCH] D78795: [Support] Add raw_ostream_iterator: ostream_iterator for raw_ostream.

Thu Mar 4 12:49:45 PST 2021

nlguillemot added a comment.

Reverted since there are some build errors on Windows bots. Here's the error log:

  [739/841] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\raw_ostream_test.cpp.obj
  FAILED: unittests/Support/CMakeFiles/SupportTests.dir/raw_ostream_test.cpp.obj 
  C:\PROGRA~2\MICROS~3\2019\PROFES~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iunittests\Support -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\unittests\Support -Iinclude -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\utils\unittest\googletest\include -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\utils\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zi /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -w
  d4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Founittests\Support\CMakeFiles\SupportTests.dir\raw_ostream_test.cpp.obj /Fdunittests\Support\CMakeFiles\SupportTests.dir\ /FS -c C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\unittests\Support\raw_ostream_test.cpp
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29333\include\xutility(1492): error C2280: 'llvm::raw_ostream_iterator<char,char> &llvm::raw_ostream_iterator<char,char>::operator =(const llvm::raw_ostream_iterator<char,char> &)': attempting to reference a deleted function
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(776): note: compiler has generated 'llvm::raw_ostream_iterator<char,char>::operator =' here
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(776): note: 'llvm::raw_ostream_iterator<char,char> &llvm::raw_ostream_iterator<char,char>::operator =(const llvm::raw_ostream_iterator<char,char> &)': function was implicitly deleted because 'llvm::raw_ostream_iterator<char,char>' has a data member 'llvm::raw_ostream_iterator<char,char>::OutStream' of reference type
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(731): note: see declaration of 'llvm::raw_ostream_iterator<char,char>::OutStream'
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29333\include\xutility(4429): note: see reference to function template instantiation 'void std::_Seek_wrapped<_OutIt,_OutIt>(_Iter &,_UIter &&)' being compiled
         with
         [
             _OutIt=llvm::raw_ostream_iterator<char,char>,
             _Iter=llvm::raw_ostream_iterator<char,char>,
             _UIter=llvm::raw_ostream_iterator<char,char>
         ]
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\unittests\Support\raw_ostream_test.cpp(456): note: see reference to function template instantiation '_OutIt std::copy<InputIt,llvm::raw_ostream_iterator<char,char>>(_InIt,_InIt,_OutIt)' being compiled
         with
         [
             _OutIt=llvm::raw_ostream_iterator<char,char>,
             InputIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<char>>>,
             _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<char>>>
         ]
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\unittests\Support\raw_ostream_test.cpp(475): note: see reference to function template instantiation 'std::string `anonymous-namespace'::iterator_str<char,std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Elem>>>>(InputIt,InputIt)' being compiled
         with
         [
             _Elem=char,
             InputIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<char>>>
         ]
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29333\include\xutility(1492): error C2280: 'llvm::raw_ostream_iterator<int,char> &llvm::raw_ostream_iterator<int,char>::operator =(const llvm::raw_ostream_iterator<int,char> &)': attempting to reference a deleted function
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(776): note: compiler has generated 'llvm::raw_ostream_iterator<int,char>::operator =' here
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(776): note: 'llvm::raw_ostream_iterator<int,char> &llvm::raw_ostream_iterator<int,char>::operator =(const llvm::raw_ostream_iterator<int,char> &)': function was implicitly deleted because 'llvm::raw_ostream_iterator<int,char>' has a data member 'llvm::raw_ostream_iterator<int,char>::OutStream' of reference type
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Support/raw_ostream.h(731): note: see declaration of 'llvm::raw_ostream_iterator<int,char>::OutStream'
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29333\include\xutility(4429): note: see reference to function template instantiation 'void std::_Seek_wrapped<_OutIt,_OutIt>(_Iter &,_UIter &&)' being compiled
         with
         [
             _OutIt=llvm::raw_ostream_iterator<int,char>,
             _Iter=llvm::raw_ostream_iterator<int,char>,
             _UIter=llvm::raw_ostream_iterator<int,char>
         ]
  C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\unittests\Support\raw_ostream_test.cpp(466): note: see reference to function template instantiation '_OutIt std::copy<InputIt,llvm::raw_ostream_iterator<int,char>>(_InIt,_InIt,_OutIt)' being compiled
         with

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78795/new/

https://reviews.llvm.org/D78795