[PATCH] D97722: [NewPM] Revamp pass names

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 12:22:08 PST 2021


bjope added a comment.

I guess it wouldn't hurt if the pass names generally would match with the DEBUG_TYPE.

Using the same source of information is nice as it kind of ensures that the same name would be used when doing `-debug-only=<name>`, `-start-before=<name>`, `-passes=<name>`, `-print-after=<name>` etc. And I think that in the legacy PM this usually is handled by using the DEBUG_TYPE macro also when doing INITIALIZE_PASS_BEGIN etc (at least in most CodeGen passes).

A problematic thing with that here is that you can't simply move the DEBUG_TYPE definitions into the header files (well, it might be technically possible, but it might be problematic when including several header files that define the macros). One could ofcourse implement the `name()` methods in the the .cpp file, but that is also a bit messier implementation-wise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97722/new/

https://reviews.llvm.org/D97722



More information about the llvm-commits mailing list