[compiler-rt] 1be9797 - Change instrprof LLVM_VP_MAX_NUM_VALS_PER_SITE threshold.

Mitch Phillips via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 12:14:07 PST 2021


Author: Mitch Phillips
Date: 2021-03-04T12:13:47-08:00
New Revision: 1be97975ccc6d98848868ecb59703156b180b08c

URL: https://github.com/llvm/llvm-project/commit/1be97975ccc6d98848868ecb59703156b180b08c
DIFF: https://github.com/llvm/llvm-project/commit/1be97975ccc6d98848868ecb59703156b180b08c.diff

LOG: Change instrprof LLVM_VP_MAX_NUM_VALS_PER_SITE threshold.

We're having flaky failures on this test on the sanitizer slow
buildbot. Not per-run flaky, but it'll be green for a while, then red
for a while. I suspect that changes in codegen are causing the
LLVM_VP_MAX_NUM_VALS_PER_SITE=150 to be above and below the limit
sporadically. The limit on my machine using lld and a non-bootstrapped
compiler is 175, but the bot uses GNU ld and ld.gold at different
points, which could be affecting behaviour.

Change this threshold to LLVM_VP_MAX_NUM_VALS_PER_SITE=130 in order to
try and get it below the failure point, at least for the foreseeable
future.

http://lab.llvm.org:8011/#/builders/37/builds/2744

Added: 
    

Modified: 
    compiler-rt/test/profile/Linux/instrprof-value-prof-warn.test

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/profile/Linux/instrprof-value-prof-warn.test b/compiler-rt/test/profile/Linux/instrprof-value-prof-warn.test
index 6ca1603fb244..de8407d6aef2 100644
--- a/compiler-rt/test/profile/Linux/instrprof-value-prof-warn.test
+++ b/compiler-rt/test/profile/Linux/instrprof-value-prof-warn.test
@@ -1,7 +1,7 @@
 RUN: %clang_pgogen -O2 -mllvm -disable-vp=false -mllvm -vp-static-alloc=true -DSTRESS=1 -o %t.ir.warn  %S/../Inputs/instrprof-value-prof-real.c
 RUN: env LLVM_PROFILE_FILE=%t.ir.profraw LLVM_VP_MAX_NUM_VALS_PER_SITE=255  %run %t.ir.warn 2>&1 |FileCheck --check-prefix=WARNING %s
 #  Test that enough static counters have been allocated
-RUN: env LLVM_PROFILE_FILE=%t.ir.profraw LLVM_VP_MAX_NUM_VALS_PER_SITE=150  %run %t.ir.warn 2>&1 |FileCheck --check-prefix=NOWARNING --allow-empty %s
+RUN: env LLVM_PROFILE_FILE=%t.ir.profraw LLVM_VP_MAX_NUM_VALS_PER_SITE=130  %run %t.ir.warn 2>&1 |FileCheck --check-prefix=NOWARNING --allow-empty %s
 
 # WARNING: LLVM Profile Warning:
 # NOWARNING-NOT: LLVM Profile Warning:


        


More information about the llvm-commits mailing list