[PATCH] D97969: [SelectionDAG] Assert that operands to SelectionDAG::getNode are not DELETED_NODE to catch issues like PR49393 earlier.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D97969#2604352 <https://reviews.llvm.org/D97969#2604352>, @lebedev.ri wrote:

> Won't be `SDValue::Node` deallocated by then, or worse, potentially reallocated?
> I guess that is still fine because it would trip ASAN?

When an SDNode is deallocated it gets remembered in a free list in the RecylingAllocator. The opcode field had __asan_unpoison_memory_region called on it. See SelectionDAG::DeallocateNode


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97969/new/

https://reviews.llvm.org/D97969