[PATCH] D97748: [SystemZ][z/OS] Add support to validate a HLASM Label.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 09:17:21 PST 2021


hubert.reinterpretcast added a comment.

In D97748#2600624 <https://reviews.llvm.org/D97748#2600624>, @anirudhp wrote:

> For now, We don’t have a firm decision on whether we will implement/support pragma convert. I understand that if it is supported, it will be a problem since the character values for the national characters will be different based on the encoding. At a future point, when we have more information, we can come back and review whether certain applicable functions would need to take the encoding into account, or, whether it can be designed in a way such that for example, everything is encoded in UTF-8 and the emission/translation is handled elsewhere (preferably much earlier than the respective backend). For now, I'm assuming the current implementation is fine.

And the current implementation here expects UTF-8 (or that's what the internal character encoding is assumed to be anyway). There's a patch for `-fexec-charset` and the string being parsed here went into the IR in what form?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97748/new/

https://reviews.llvm.org/D97748



More information about the llvm-commits mailing list