[PATCH] D97797: [lld-macho][nfc] Parse more options using getLastArg{Value}
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 4 09:10:54 PST 2021
int3 added inline comments.
================
Comment at: lld/MachO/Driver.cpp:594
-static void handleUndefined(const opt::Arg *arg) {
- StringRef treatmentStr = arg->getValue(0);
----------------
thakis wrote:
> nit: the `handle` prefix is somewhat common for option handling cf eg handleUndefined in the ELF linker
hm but the `handle` functions in ELF seem to take the arg / arg value. Whereas functions that take the ArgList and do both arg lookup + handling seem to be prefixed with `get`, e.g. getReproduceOption.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97797/new/
https://reviews.llvm.org/D97797
More information about the llvm-commits
mailing list