[PATCH] D95026: [SimplifyCFG] Update FoldBranchToCommonDest to be poison-safe

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

Sorry for the delay. This LG with a nit, but please land this only after the loop unswitch change.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2964
+    NewCondV = Builder.CreateBinOp(Opc, PBI->getCondition(), BICond, "or.cond");
+  Instruction *NewCond = cast<Instruction>(NewCondV);
   PBI->setCondition(NewCond);
----------------
Why do we need NewCondV and NewCond? setCondition should accept a Value without the Instruction cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95026/new/

https://reviews.llvm.org/D95026