[PATCH] D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

This looks good to me. @MaskRay any comments?



================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:165
 
+  bool isUImm2() const { return isUImm<2>(); }
   bool isUImm5() const { return isUImm<5>(); }
----------------
These helpers look unnecessary, since the actual function call is so simple...


================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:416
+OperandMatchResultTy CSKYAsmParser::parseBaseRegImm(OperandVector &Operands) {
+  assert(!getLexer().isNot(AsmToken::LParen));
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94007/new/

https://reviews.llvm.org/D94007