[PATCH] D97895: [RISCV] Starting fixing issues that prevent us from testing vXi64 intrinsics on RV32.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2454
+    // point.
+    //   vmv.v.x vX, hi
+    //   vsll.vx vX, vX, /*32*/
----------------
craig.topper wrote:
> I was thinking maybe we just need two slide1ups using SEW=32 with VL set to 2 so that we don't slide anything but the scalars we're inserting.
Crafty; I like it. Doing that later along with INSERT_VECTOR_ELT would be my preferred way to go.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:102
+  // for the VL value to be used for the operation.
+  VMV_S_X_VL,
   // VMV_X_S matches the semantics of vmv.x.s. The result is always XLenVT sign
----------------
craig.topper wrote:
> I think @frasercrmck has a patch that adds VMV_S_XF_VL which I think I can migrate to once its committed.
Yeah you should be good to go with that now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97895/new/

https://reviews.llvm.org/D97895