[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:137
+  ///    Number of vector elements.
+  Value *createStepVector(IRBuilder<> &Builder, Type *LaneTy, int32_t NumElems);
+
----------------
ctetreau wrote:
> This could conceivably work for scalable vectors after https://lists.llvm.org/pipermail/llvm-dev/2021-January/147943.html is merged
Yep. We can switch to stepvector once its merged.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:322-323
+  unsigned OC = VPI.getFunctionalOpcode();
+#define FIRST_BINARY_INST(X) unsigned FirstBinOp = X;
+#define LAST_BINARY_INST(X) unsigned LastBinOp = X;
+#include "llvm/IR/Instruction.def"
----------------
ctetreau wrote:
> should these get undefined after the include?
These get undefined in the included file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203