[PATCH] D97858: [AArch64][SVE] Fold vector ZExt/SExt into gather loads where possible

Joe Ellis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 07:00:08 PST 2021


joechrisellis added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14418
+
+      return DAG.getNode(NewOpc, DL, {ResVT, MVT::Other},
+                         {Op0, Op1, Op2, UnextendedOffset, Op4});
----------------
david-arm wrote:
> Do we not need to check the type we're extending from here? For example, what if we're extending from a vector of i8s, which isn't tested below?
Great spot -- thank you. Turns out we can only fold in `{u,s}xtw`s (`w` being the key part). :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97858/new/

https://reviews.llvm.org/D97858



More information about the llvm-commits mailing list