[PATCH] D97947: [AArch64] Force runtime unrolling for in-order scheduling models

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:980
 
+  // Force runtime unrolling for in-order models
+  UP.Runtime |= !ST->getSchedModel().isOutOfOrder();
----------------
Looks sensible to me that we do this (first) for smaller in-order cores.
>From a quick look, quite a few other targets that implement this hook have:

  // Scan the loop: don't unroll loops with calls as this could prevent
  // inlining.

Do we need that too? Have you benchmarked this, and can we try this too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97947/new/

https://reviews.llvm.org/D97947